[Rpm-maint] rpmdbAdd is gone?

[Panu Matilainen]

On 05/13/2011 04:05 PM, Michael Schroeder wrote:
> On Fri, May 13, 2011 at 04:00:59PM +0300, Panu Matilainen wrote:
>> On 05/12/2011 06:59 PM, Michael Schroeder wrote:
>>>
>>> Hmm, I see that rpmdbAdd() et al have been removed in favor
>>> of rpmts, but there don't seem to be equivalent functions.
>>> How about rpmtsHeaderAddDB() and rpmtsHeaderRemoveDB()?
>>>
>>> Patch attached.
>>
>> Well, the point of removing rpmdbAdd() and rpmdbRemove() from the API
>> was to prevent bypassing the transaction processing for any
>> install/remove actions.
>>
>> I'd rather not add them or similar functions back, but I'd like to hear
>> the use-case first - what exactly do you need them for?
>
> Well, actually to keep convertdb1 alive ;-) Ok, this is somewhat
> academic, but there might be some other use cases, IMHO the
> LSB folks sometimes discussed a way to add other installers
> that would add metadata into the rpm database.

convertdb1 very much falls into "rpm internal use" category which would 
be fine, it's the other uses of bypassing the transaction machinery that 
removal of rpmdbAdd() and rpmdbRemove() is intended to prevent.

Its not that I'm vehemently opposed to other installers being able to 
add metadata to the rpmdb, just that it should happen in a more 
controlled fashion than arbitrary programs adding and removing arbitrary 
stuff without any sort of sanity checking and transaction locking etc 
into the rpmdb.

	- Panu -