[Rpm-maint] Obsoletes handling in depends.c:rpmdbProvides()

Michael Schroeder mls at suse.de
Wed Apr 18 15:10:44 UTC 2012


Hi Panu et al,

I'm a bit confused about commit 9fb81eac. If dep is an
"Obsoletes" dependency, it uses RPMDBI_NAME instead of
RPMDBI_PROVIDENAME. It then still calls rpmdsMatchesDep().

Is that really correct? It seems to me that rpmdsMatchesDep()
always expects the "ix" argument to be an index into the
provides error, how can that work with a different db index?

Also, shouldn't it call rpmdsNVRMatchesDep() in the
obsoletes case instead of rpmdsMatchesDep() to be more
consistent with addObsoleteErasures()?

Cheers,
  Michael.

-- 
Michael Schroeder                                   mls at suse.de
SUSE LINUX Products GmbH,  GF Jeff Hawn, HRB 16746 AG Nuernberg
main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);}


More information about the Rpm-maint mailing list