[Rpm-maint] PATCH 1/2013 Take rid of redefinitions of __BEGIN_DECLS and __END_DECLS

Panu Matilainen pmatilai at laiskiainen.org
Thu Aug 15 04:51:22 UTC 2013


On 07/25/2013 06:38 PM, n54 at gmx.com wrote:
> Hello,

Hi,

> I'm attaching a patch with the following change-log:
>
> 1. Stop defining __BEGIN_DECLS and __END_DECLS in fts.h
> 2. Replace occurences of __BEGIN_DECLS with:
> extern "C" {
> 3. Replace occurences of __BEGIN_DECLS with:
> }
>
> Comment
> =======
> __BEGIN_DECLS and __END_DECLS are already defined in the NetBSD's standard C
> library as an internal definition and redefinition of it causes errors.
>
> The possible solutions are to rename the definitions or take rid of them.
>
> Actually __BEGIN_DECLS and __END_DECLS are used only once and encapsulate
> 'extern "C" {' and '}', so they aren't really helping more then obfuscating
> the code.

Cleanups always welcome. Applied, thanks for the patch!

	- Panu -


More information about the Rpm-maint mailing list