[Rpm-maint] [PATCH] drop interpreter deps when already handled

Panu Matilainen pmatilai at laiskiainen.org
Wed Sep 17 10:17:11 UTC 2014


On 09/16/2014 04:08 PM, Thierry Vignaud wrote:
> Hi
>
> The attached patch drops interpreter deps when already handled:
>
> Drop automatically generated dependencies on interpreters we either
> don't need dependencies on or that we have other dedicated dependency
> generators for making them duplicate, reducing ~5K packages'
> dependencies in repository metadata on next rebuild:
> - perl/python: we already have dedicated dependency generators for these

NAK. There's no guarantee the dedicated dependency generators emit 
anything at all for scripts, for trivial reproducers this patch breaks 
dependency generation on these scripts:

#!/usr/bin/python
print "hello\n"

or

#!/usr/bin/perl
print "hello\n"

They might seem TOO trivial, but then think just how embarrassing it 
would be to entirely miss the dependencies of scripts SO trivial :) Also 
at least in case of Python, scripts where the only emitted dependency 
comes from the shebang line are the norm, not the exception.

> Those are basically duplicates (and replacing file deps by requires on
> regular provides is good IMHO).
>
> Note that Mageia also drop requires on other but I don't submit them b/c:
> - ruby: dedicated dependency generator is not upstream
> - /bin/sh & /bin/bash: we really don't need to add these dependencies as
>    they're required by glibc and therefore guaranteed to be satisfied
>    This is not true for most distros that don't have a /bin/sh scriptlet

Seems like a bad idea to me for a number of reasons, I'd suggest 
filtering at repo metadata instead of rpm level. Your distro though...

	- Panu -



More information about the Rpm-maint mailing list