[Rpm-maint] [PATCH] perl.{prov,req} improvments

Michael Schroeder mls at suse.de
Thu Sep 18 10:38:35 UTC 2014


On Thu, Sep 18, 2014 at 01:27:17PM +0300, Ville Skyttä wrote:
> On Thu, Sep 18, 2014 at 9:38 AM, Jerome Quelin <jquelin at gmail.com> wrote:
> > This patch only acknowledges this fact, and allows _ in versions.
> 
> This results in the underscores also ending up in the Provides. I
> don't think that's a good thing as IIRC rpm's version comparison does
> not treat it the same way as perl does. So for example for module
> version spelled as 0.95_01 the Provides would also be perl($something)
> = 0.95_01. I suppose allowing the underscore would be ok if it would
> be sanitized before output, i.e. 0.95_01 would result in Provides
> perl($something) = 0.9501

Well, 0.95_01 is actually more correct than 0.9501. Perl's versions
are actually more or less floating point numbers, thus 0.9501 is
supposed to be less than 0.96.

>From rpm's side, '_' is exactly equivalent to '.', so 0.95_01 is
the same as 0.95.01, which is probably what the upstream author
indended.

Cheers,
  Michael.

-- 
Michael Schroeder                                   mls at suse.de
SUSE LINUX Products GmbH,  GF Jeff Hawn, HRB 16746 AG Nuernberg
main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);}


More information about the Rpm-maint mailing list