[Rpm-maint] [PATCH v9a 13/13] Add support for prompting the user for the password using pinentry

[Mimi Zohar]

On Tue, 2015-08-11 at 11:12 -0400, Lubos Kardos wrote:
> Hi,
> sorry for late response but I was busy with solving problems with the new
> release rpm-4.13.0-alpha. The patches look good. I have comments only about
> the last one.
> 
> The first one there is a race in pinentry patch. If I enter "password" in
> pinentry window then get_pinentry_fskpass() sometimes returns correctly
> "password" but it sometimes returns "password\nOK" or it returns NULL. I am
> not expert in pinetry protocol but recv() looks too easy to handle a protocol
> over a pipe. What if the pipe doesn't contain result in time of calling read(),
> you should read from pipe until you get what you expect and if you don't get it
> in some time then you should return error. Or what if after calling read()
> the returned buffer contains more messages, ...
> 
> The second comment. The pinentry should work in terminal without graphical
> enviroment but it doesn't work. I don't know where the problem is. If it
> worked without graphical environment then you shouldn't need a fallback for
> prompting the user directly. And I think it is not correct behavior when you
> click "Cancel" in pinentry window and then you are asked for password on
> terminal.
> 
> But I'm OK with pushing patches upstream without this last pinentry patch with
> just support for getting password directly from user without pinentry. Let me
> know if you want to fix this patch or should I push patches upstream 
> without it.

I was hoping you would agree to upstreaming the patches with just the
first patch.  :)

Thanks!

Mimi