[Rpm-maint] [RFC v4 04/11] Add support for file signatures to rpmfi and rpmfiles

[Florian Festi]

On 01/13/2015 07:33 PM, fin at linux.vnet.ibm.com wrote:

Ok, some minor knitpicks:

> This patch adds file signatures and file signature length to rpmfiles. These
> new members are set in rpmfilesPopulate, and they can be accessed with 
> rpmfiFSignature.
> 
> Signed-off-by: Fionnuala Gunter <fin at linux.vnet.ibm.com>


> +char *rpmfiFSignatureHex(rpmfi fi)
Missing whitespace after "*".


>      if (!(flags & RPMFI_NOFILERDEVS))
> +
>  	_hgfi(h, RPMTAG_FILERDEVS, &td, scareFlags, fi->frdevs);
Errous empty line.

> +/** \ingroup rpmfi
> + * Return current file (hex) signature of file info set iterator.
> + * The file info set iterator stores files signatures in binary format to
> + * conserve memory, this converts the binary data back to hex presentation used
> + * in headers.
> + */
> +char * rpmfiFSignatureHex(rpmfi fi);

char * rpmfilesFSignatureHex(rpmfi fi);
missing (ok, can be argued if really needed)


> +    RPMFI_NOFILESIGNATURES	= (1 << 18),
Not actually used. Should probably guard the new code in rpmfilesPopulate()

Florian

-- 

Red Hat GmbH, http://www.de.redhat.com/ Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael
O'Neill, Charles Peters