[Rpm-maint] [PATCH v2 1/2] Extend header size to 256MB due to file signatures

[Stefan Berger]

"Rpm-maint" <rpm-maint-bounces at lists.rpm.org> wrote on 04/29/2016 01:42:06 
PM:

> 
> On Fri, 29 Apr 2016, Stefan Berger wrote:
> 
> > From: Stefan Berger <stefanb at us.ibm.com>
> > 
> > Extend the header size to 256MB in case an RPM has a lot of files
> > and the file signatures do not fit within the current limit of 16MB.
> 
> a (huge) fixed extension allocation, rather than writing a 
> 'chained block allocation on demand' mechanism seems 
> 'un-Unixy' and a kludge 
> 
> ... in a current install of 1900 packages, only 300 are of a 
> size greater than 256MBy.  The penalty for a repository to 
> carry around that unused slack space is an installation image 
> is huge

No space is allocated (for file signatures) inside an RPM's header that 
isn't needed. 

So maybe the title of the commit message is misleading and it should say 
that we are extending the 'limit' of the header size to 256MB. There are 
checks in the code that make rpm fail if the header becomes larger than 
that limit. 16MB weren't enough, so we extended the limit to 256MB. 
There's no space allocation for 256MB per package that would just carry 
around zeroes, if that's what you meant.

   Stefan

> 
> I would recommend that if a bigger header space requirement 
> exists, that it be done in a fashion other than 'using a 
> bigger hammer'
> 
> -- Russ herrold
> _______________________________________________
> Rpm-maint mailing list
> Rpm-maint at lists.rpm.org
> http://lists.rpm.org/mailman/listinfo/rpm-maint
> 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20160429/69854571/attachment.html>