[Rpm-maint] Planning for rpm 4.13.0 (-rc2)

[Gleb Fotengauer-Malinovskiy]

On Fri, Dec 09, 2016 at 06:24:02PM +0200, Panu Matilainen wrote:
> On 10/17/2016 11:05 AM, Panu Matilainen wrote:
> > On 10/16/2016 10:15 AM, Dmitry V. Levin wrote:
> >> Hi,
> >>
> >> On Fri, Oct 14, 2016 at 04:33:00PM +0300, Panu Matilainen wrote:
> >>>
> >>> Hey folks,
> >>>
> >>> Time to get rpm 4.13.0 out of the door. But in order to do that, we'll
> >>> need to cut -rc2 first, there's just too much change to jump right into
> >>> final.
> >>>
> >>> The idea is to get -rc2 out next week (ie by Oct 21st at latest). If all
> >>> goes well we'll just rename that to -final in a few weeks time, if all
> >>> goes to hell we'll just have another -rc. Which I really, really dont
> >>> want to happen. So what I've planned for -rc2 is this rather
> >>> conservative cherry-picks from git master on top of the 4.13.x branch:
> >> [...]
> >>> Anyway, the list above is not set in stone, otherwise there'd be little
> >>> point in posting it here. If you think something absolutely critical is
> >>> missing from that list, or that something should not be there, now is
> >>> the time to speak up.
> >>
> >> Please include rpmdb.c fixes (commits 4c6e51e2 and e5d3b9f6), they are
> >> essential for apt-rpm.
> >
> > Request noted, but remember this is an ages old runtime bug, finally
> > fixed. Whether it gets fixed or not does not affect eg package or
> > API/ABI compatibility, so it can just as well be fixed in 4.13.1.
> >
> 
> So... in one of my weak moments I ended up letting these patches in 
> 4.13.0 against my own guidelines and here's my reward: commit 4c6e51e2 
> breaks cleaning up the locks on ctrl-c and so we have a wholly unwanted 
> and unnecessary regression in 4.13.0. Yeah it doesn't double free 
> because it doesn't free at all, at least in this case - yay.

Oh, I'm sorry.

I think, my commits both break cleanup of database locks. :(

> To reproduce, run 'rpm -qa' as root, hit ctrl-c and witness locks left 
> behind, eg:
> 
> [root at mangusti ~]# rpm -qa|grep anything
> ^C
> [root at mangusti ~]# rpm -q anything
> BDB2053 Freeing read locks for locker 0x34a: 9666/140299205872448
> BDB2053 Freeing read locks for locker 0x34b: 9666/140299205872448
> BDB2053 Freeing read locks for locker 0x34c: 9666/140299205872448
> package anything is not installed
> [root at mangusti ~]#
> 
> 	- Panu -

-- 
glebfm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-regression-in-cleanup-of-database-locks.patch
Type: text/x-patch
Size: 1254 bytes
Desc: not available
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20161210/89e22733/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Revert-rpmdb.c-rpmdbCheckTerminate-return-non-zero-o.patch
Type: text/x-patch
Size: 1141 bytes
Desc: not available
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20161210/89e22733/attachment-0001.bin>