[Rpm-maint] [rpm-software-management/rpm] Detect and fail build on more than one %changelog section in spec (fe8c825)

[Panu Matilainen]

On 05/26/2016 10:58 AM, Pierre-Antoine Grégoire wrote:
> Thank you @pmatilai
>
> I'll take this into consideration for my specs, though incidentally (because it worked as one would expect it to work before) it feels like a regression.
>
> Practically, (using versions prior to 4.12) a spec with multiple changelogs using:
> %changelog -n subpackagename
> effectively adds that specific changelog to the sub-package itself, distinctly from the "main" changelog.
> They are not slopped, though maybe this is a bug and not a feature.
> It is very practical though.

%changelog does not accept any options (never has), so its yet another 
bug that it doesn't complain about eg -n foo being passed.

And ok, looking at the code the %changelog is slopped to current head of 
packages list, so I guess if you interleave %changelog sections with 
%package sections I could imagine they do end up in different packages. 
And yes, its not a feature but a bug.

> e.g. if one packages a product in distinct client and server packages with distinct versions, a common changelog would make little sense, wouldn't it? Moreover because changelog will be written in all produced packages.
>
> This is enhanced by the fact that (once again effectively, but maybe not by design?) sub-packages can have distinct versions, which make it tricky to distinguish entries in the changelog.
>
> If package A has version 1.0-0 and sub-package B has version 1.0.1-1, what is the changelog going to look like?
> Or therefore should versions be block from override at sub-package level?

Changelog does not know anything about versions. If you refer to 
%{version} (or any other spec-level tag macro) in the spec, the last one 
defined is active at any given point.

	- Panu -

>
> ---
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> https://github.com/rpm-software-management/rpm/commit/fe8c82549aee176524e0e94786596683cd7a402d#commitcomment-17626029
>



---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/commit/fe8c82549aee176524e0e94786596683cd7a402d#commitcomment-17626193
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20160526/3c738e30/attachment.html>