[Rpm-maint] [rpm-software-management/rpm] build: better warning for non-unique %files section (#91)

Panu Matilainen notifications at github.com
Thu Sep 15 10:01:57 UTC 2016


pmatilai requested changes on this pull request.

Why not just:

@@ -73,7 +73,8 @@ int parseFiles(rpmSpec spec)
      * Warn but preserve behavior, except for leaking memory.
      */
     if (pkg->fileList != NULL) {
-       rpmlog(RPMLOG_WARNING, _("line %d: second %%files\n"), spec->lineNum);
+       rpmlog(RPMLOG_WARNING, _("line %d: second %%files for package %s\n"),
+               spec->lineNum, rpmstrPoolStr(pkg->pool, pkg->name));
        pkg->fileList = argvFree(pkg->fileList);
        
     }




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/91#pullrequestreview-130436
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20160915/cdfb19c9/attachment-0001.html>


More information about the Rpm-maint mailing list