[Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

[Stephen Gallagher]

sgallagher commented on this pull request.



> +int DSA_SIG_set0(DSA_SIG *sig, BIGNUM *r, BIGNUM *s)
+{
+    if (!sig) return 0;
+
+    if (r) {
+        sig->r = r;
+    }
+
+    if (s) {
+        sig->s = s;
+    }
+
+    return 1;
+}
+#endif /* HAVE_DSA_SIG_SET0 */
+

I'm not really sure what you mean by "release" them? The way this function is expected to work is that it updates any values that aren't NULL and does not change any that are. Or at least, that's the way that the OpenSSL 1.1.0 version implements them.

Also, these are "set" not "assigned", so it's not expected that this function should be owning their memory management either. Meaning I shouldn't be calling BN_free() before assigning the new value.

Am I way off-base here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170206/4f6374f4/attachment.html>