[Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

[Stephen Gallagher]

sgallagher commented on this pull request.



> +    switch (num) {
+    case 0:
+        if (!bn) {
+            bn = sig->bn = BN_new();
+        }
+        if (!bn) return 1;
+
+        /* Create a BIGNUM from the signature pointer.
+           Note: this assumes big-endian data as required
+           by the PGP multiprecision integer format
+           (RFC4880, Section 3.2)
+           This will be useful later, as we can
+           retrieve this value with appropriate
+           padding. */
+        bn = BN_bin2bn(p+2, mlen, bn);
+        if (!bn) return 1;

Mostly I was copying that from the beecrypt and NSS implementations, where the signature was padded before comparison. Are you saying I can skip the padding entirely at https://github.com/rpm-software-management/rpm/pull/129/files/a7bc1e416e2f0f193be63317701bd3b18e2934b6#diff-763b444493abc6d6f5549dafd08d9d07R523 ?

This is definitely a place where I don't actually know what I'm doing...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170206/3ff7338b/attachment.html>