[Rpm-maint] [rpm-software-management/rpm] Support pbzip command for multicore environment (#117)

[Igor Gnatenko]

ignatenkobrain commented on this pull request.



> @@ -1,6 +1,9 @@
 Historic. For more recent changes, look at git history or at
 ChangeLog from tarballs.
 
+4.4.2 -> 4.13:
+	- builds against pbzip2 1.0

look few lines above. it's deprecated.

> @@ -368,6 +368,11 @@ static rpmRC writeRPM(Package pkg, unsigned char ** pkgidp,
 	    /* Add prereq on rpm version that understands bzip2 payloads */
 	    (void) rpmlibNeedsFeature(pkg, "PayloadIsBzip2", "3.0.5-1");
 #endif
+#if HAVE_PBZLIB_H
+	} else if (rstreq(s+1, "pbzdio")) {
+	    compr = "pbzip2";
+	    (void) rpmlibNeedsFeature(pkg, "PayloadIsPBzip2", "3.0.5-1");

I think 3.0.5-1 doesn't apply here and should be 4.14.0-1

> @@ -1227,6 +1227,11 @@ static const struct rpmlibProvides_s rpmlibProvides[] = {
 	(RPMSENSE_RPMLIB|RPMSENSE_EQUAL),
     N_("package payload can be compressed using bzip2.") },
 #endif
+#if HAVE_PBZLIB_H
+    { "rpmlib(PayloadIsPBzip2)",		"3.0.5-1",

same here.

> @@ -156,6 +157,9 @@
 #	The path to the bzip2 executable (legacy, use %{__bzip2} instead).
 %_bzip2bin		%{__bzip2}
 
+#	The path to the pbzip2 executable (legacy, use %{__pbzip2} instead).

I don't think adding deprecated things is good idea

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/117#pullrequestreview-15459357
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170106/de8ac15b/attachment-0001.html>