[Rpm-maint] [rpm-software-management/rpm] Return error exit status when make check is failed. (#248)

[Jun Aruga]

Right now `make check` returns success exit status: 0 when the tests are failed.

```
$ make check
...
## ------------- ##
## Test results. ##
## ------------- ##

ERROR: All 358 tests were run,
21 failed (2 expected failures).
## ------------------------- ##
## rpmtests.log was created. ##
## ------------------------- ##
...
```

```
$ echo $?
0
```

Because the logic to succeed forcely is added below commit.
But I think that it is not good. Because we can not detect failed tests for example in `rpm.spec` check section.

https://github.com/rpm-software-management/rpm/commit/52bc67436f5bc28d2bd08a9fd3498cf16d5817bb

After this modification, `make check` returns error exit status.

```
$ make check
...
## ------------- ##
## Test results. ##
## ------------- ##  

ERROR: All 358 tests were run,
21 failed (2 expected failures).
## ------------------------- ##
## rpmtests.log was created. ##
## ------------------------- ##
...
```

```
$ echo $?
2
```

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/248

-- Commit Summary --

  * Return error exit status when make check is failed.

-- File Changes --

    M tests/Makefile.am (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/248.patch
https://github.com/rpm-software-management/rpm/pull/248.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/248
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170703/c8d94818/attachment-0001.html>