[Rpm-maint] [PATCH] config: Detect major/minor warnings and include the correct system header.

[Florian Festi]

Pushed.

On 07/21/2017 01:24 PM, Mark Wielaard wrote:
> Hi,
> 
> On Thu, 2017-07-20 at 17:06 +0300, Dmitry V. Levin wrote:
>> I'm not sure what sys/mkdev.h does, but glibc's sys/sysmacros.h certainly
>> undefines major, minor, and makedev prior to defining its own versions of
>> these macros.
>>
>> My guess is that these undefs are not needed.
> 
> You are right. This makes the patch simpler. Now we only need to fix the
> AC_HEADER_MAJOR check. Cleaned up patch attached. Retested on rhel7 and
> fedora26.
> 
> sys/mkdev.h is a solaris/bsd thing. I checked and they also undef the
> macros before (re)defining them. Although there they might not be
> defined in another header in the first place.
> 
> Thanks,
> 
> Mark
> 
> 
> 
> _______________________________________________
> Rpm-maint mailing list
> Rpm-maint at lists.rpm.org
> http://lists.rpm.org/mailman/listinfo/rpm-maint
> 


-- 

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham,
Michael O'Neill