[Rpm-maint] [PATCH] generateBuildIDs: Don't warn or error for object files without build-id.
Mark Wielaard
mjw at redhat.com
Thu Mar 9 21:29:42 UTC 2017
On Thu, 2017-03-09 at 12:22 +0200, Panu Matilainen wrote:
> On 03/09/2017 10:34 AM, Mark Wielaard wrote:
> > From: Mark Wielaard <mark at klomp.org>
> >
> > Only loadable ELF images (executables, shared libraries, kernel modules)
> > should have build-ids. So don't warn or error out when an object file is
> > found without one.
> >
> > Signed-off-by: Mark Wielaard <mark at klomp.org>
>
> Applied, thanks.
Thanks, but unfortunately my patch was not correct.
It suppressed the warning/error, but it still failed the build.
Now without giving any clear message. And because we also failed to set
processingFailed the error message if generateBuildIDs failed for any
reason the error message the user got was incomprehensible. The attached
patch fixes both these issues.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-generateBuildIDs-Fix-error-handling.patch
Type: text/x-patch
Size: 2698 bytes
Desc:
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170309/a17cea2b/attachment.bin>
More information about the Rpm-maint
mailing list