[Rpm-maint] [PATCH] generateBuildIDs: Don't warn or error for object files without build-id.

[Panu Matilainen]

On 03/09/2017 11:29 PM, Mark Wielaard wrote:
> On Thu, 2017-03-09 at 12:22 +0200, Panu Matilainen wrote:
>> On 03/09/2017 10:34 AM, Mark Wielaard wrote:
>>> From: Mark Wielaard <mark at klomp.org>
>>>
>>> Only loadable ELF images (executables, shared libraries, kernel modules)
>>> should have build-ids. So don't warn or error out when an object file is
>>> found without one.
>>>
>>> Signed-off-by: Mark Wielaard <mark at klomp.org>
>>
>> Applied, thanks.
>
> Thanks, but unfortunately my patch was not correct.
> It suppressed the warning/error, but it still failed the build.
> Now without giving any clear message. And because we also failed to set
> processingFailed the error message if generateBuildIDs failed for any
> reason the error message the user got was incomprehensible. The attached
> patch fixes both these issues.
>

Ok. In the future if you're unsure about a patch (such as kernel build 
test still running :) please either postpone sending until test 
completes or make a note the patch is still in testing so we'll know to 
hold off a bit.

You probably were not expecting us to apply the patch so soon from past 
experiences but I'm trying to do something about *that* here...

	- Panu -