[Rpm-maint] [PATCH] debugedit: Fix off-by-one adding DW_FORM_string replacement slashes.

Panu Matilainen pmatilai at redhat.com
Wed Mar 22 12:55:05 UTC 2017


On 03/21/2017 05:57 PM, Mark Wielaard wrote:
> From: Mark Wielaard <mark at klomp.org>
>
> We would put one too many slashes in between the new dest_dir and file name
> part of the replacement of a DW_FORM_string in the .debug_info. If there
> was file part then we would overwrite the first character of the name. If
> there was no file part at all then this would overwrite the zero terminator
> and cause a crash reading the rest of the data.
>
> A crash did happen while building the docker package on fedora s390x.
> https://bugzilla.redhat.com/show_bug.cgi?id=1434347
>
> The reason neither issue would normally trigger is because if we do detect
> that the dest_dir is larger than the base_dir we refuse to replace anything.
>
> Signed-off-by: Mark Wielaard <mark at klomp.org>

Applied, thanks!

	- Panu -



More information about the Rpm-maint mailing list