[Rpm-maint] [rpm-software-management/rpm] Add support for debugsource subpackages and split debuginfo subpackages (#180)

[Panu Matilainen]

pmatilai commented on this pull request.



> +    RPMTAG_PACKAGER,
+    RPMTAG_DISTRIBUTION,
+    RPMTAG_DISTURL,
+    RPMTAG_VENDOR,
+    RPMTAG_ICON,
+    RPMTAG_URL,
+    RPMTAG_VCS,
+    RPMTAG_CHANGELOGTIME,
+    RPMTAG_CHANGELOGNAME,
+    RPMTAG_CHANGELOGTEXT,
+    RPMTAG_PREFIXES,
+    RPMTAG_DISTTAG,
+    RPMTAG_BUGURL,
+    0
+};
+

Hmm, AFAICS that only differs by RPMTAG_GROUP from copyTagsDuringParse. I can see wanting to use specific group for debuginfo, but  why not reuse copyTagsDuringParse and then just delete RPMTAG_GROUP? Would be less duplication - unless there are other reasons and differences that aren't obvious from the outset.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/180#pullrequestreview-29952054
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170330/19ca93a5/attachment.html>