[Rpm-maint] [rpm-software-management/rpm] Add support for debugsource subpackages and split debuginfo subpackages (#180)

[Panu Matilainen]

pmatilai commented on this pull request.



> +
+/* add the debug dwz files to package pkg.
+ * return 1 if something was added, 0 otherwise. */
+static int addDebugDwz(Package pkg, char *buildroot)
+{
+    int ret = 0;
+    char *path = NULL;
+    struct stat sbuf;
+
+    rasprintf(&path, "%s/usr/lib/debug/.dwz", buildroot);
+    if (lstat(path, &sbuf) == 0 && S_ISDIR(sbuf.st_mode)) {
+	if (!pkg->fileList) {
+	    argvAdd(&pkg->fileList, "%defattr(-,root,root)");
+	    argvAdd(&pkg->fileList, "%dir /usr/lib/debug");
+	}
+	argvAdd(&pkg->fileList, "/usr/lib/debug/.dwz");

There are quite a few repetitions of /usr/lib/debug and its variants, please use a preprocessor macro instead (there's eg DEBUGPATH already).

Rpm macros for all these paths would be even nicer but that's well beyond the scope here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/180#pullrequestreview-29952144
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170330/86f7490b/attachment.html>