[Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#360)

[Panu Matilainen]

pmatilai commented on this pull request.



> @@ -146,6 +244,8 @@ static void processVerDef(Elf_Scn *scn, GElf_Shdr *shdr, elfInfo *ei)
 		    continue;
 		} else if (soname && !soname_only && !skipPrivate(s)) {
 		    addDep(&ei->provides, soname, s, ei->marker);
+		    if (multiarch_deps)
+			addDep(&ei->provides, soname, s, ei->archmarker);

Hmm, shouldn't the non-archmarker addDep() be behind an else, like it is in all the other similar cases?

And in that case, the multiarch_deps condition is better handled inside addDep() rather than repeating it several times in the codebase (and getting it wrong in some).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/360#pullrequestreview-99582429
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20180226/a460a0ea/attachment.html>