[Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#360)

[Panu Matilainen]

pmatilai commented on this pull request.



>  	    addDep(&ei->provides, ei->soname, NULL, ei->marker);
+	    if (multiarch_deps)
+		addDep(&ei->provides, ei->soname, NULL, ei->archmarker);
+	}

Oh and ditto here too, shouldn't the non-archmarker addDep() be behind an else?

If the answer is "no" for both these cases I think it'd be good to explain why that is (in the commit message or code comment)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/360#pullrequestreview-99583187
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20180226/4985ffad/attachment.html>