[Rpm-maint] [rpm-software-management/rpm] 3 cleanup fixes (#359)

[Panu Matilainen]

The holdup here has been the rpmdbClose() changes, I've gotten rather wary of changes to that area due to recent fix-regression-fix-regression round - see commit 4c6e51e2c0e3deeb052ae3c47115b6d10cb0d696 which your change almost reverts, and then the subsequent fixes and reverts in the history. We need to be sure it doesn't reintroduce the double-free (which doesn't occur with rpm itself, only in a specific API usage) which means I (or somebody) needs to chase down the reproducer for the original problem etc.

In the meanwhile I merged the other changes, those were obvious enough. And FWIW, this is a good example of why combining unrelated changes into a single PR is not necessarily a good idea.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/359#issuecomment-368809438
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20180227/f7f68c0d/attachment-0001.html>