[Rpm-maint] [rpm-software-management/rpm] Use full build template (#480)

[Jeff Johnson]

You are correct that the templating goes way way back to 1999.

The exit 0 at the end of %___build post is totally Wong and always has been. My name may even be on the check-in: if so the exit 0 was due to one of the following:

1) some n00bie employee/packager was incapable of understanding that a failing if statement at the end of a shell script becomes the exit code
2) I was ordered to make the change, 'twas a job mon
3) I was too exhausted to notice or fix the issue, again twas a job mon.

An additional rpmExpand() hurts nothing except mls at suse's sensibilities (there's another issue here about an unnecessary rpmExpand with empty strings reported by mls at suse ;-)

Yes %setup/%patch are not problematic for debbuild because you had to reimplement. However using %buildsubdir, which is dynamically set by %setup parsing, has confused lots of people over the years.

There really isn't anything remarkable about macro expansion: it's just recursive string substitution until you start getting into using macros as a diversion to an executable.

Note however that macro definitions are stacks: a new definition hides, not replaces, the previous definition. That is bit surprising to many programmers

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/480#issuecomment-408530165
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20180727/25f81fb3/attachment.html>