[Rpm-maint] [rpm-software-management/rpm] Fix a problem where scripts would fail to run with exit code 127 (#447)

[Richard Purdie]

Commit 9c3e5de3240554c8ea1b29d52eeadee4840fefac,  "Factor out
and unify setting CLOEXEC" moved code which set the xx variable.

There are now ways this function can fail to set xx at all leaving
it at the mercy of the compiler. gcc 4.8.5 for example will leave
this with a non-zero value causing scripts to fail.

The original code here checked for return codes of functions
which no longer set xx. As far as I can tell the best thing is
to simple remove the seemingly erroneous test and make things
deterministic!

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/447

-- Commit Summary --

  * Fix a problem where scripts would fail to run with exit code 127

-- File Changes --

    M lib/rpmscript.c (4)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/447.patch
https://github.com/rpm-software-management/rpm/pull/447.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/447
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20180606/d8d6c2d2/attachment.html>