[Rpm-maint] [rpm-software-management/rpm] Add support for sorting caret ('^') higher than base version (#597)

Neal Gompa (ニール・ゴンパ) notifications at github.com
Fri Nov 16 13:39:30 UTC 2018


Conan-Kudo approved this pull request.

The changes look good, but here's a suggestion for the function name change.

> @@ -228,12 +228,12 @@ static rpmRC processScriptFiles(rpmSpec spec, Package pkg)
     return rc;
 }
 
-static int haveTildeDep(Package pkg)
+static int haveCharInDep(Package pkg, char c)

A better name might be `haveModifierInDep`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/597#pullrequestreview-175803201
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20181116/3a065172/attachment-0001.html>


More information about the Rpm-maint mailing list