[Rpm-maint] [PATCH] add support for scriptlet deps in generated deps

[Panu Matilainen]

On 9/12/18 3:25 PM, Thierry Vignaud wrote:
> In Mageia, we eg had:
> 1) manual "requires(post)" or "requires(posttrans): info-install"
>      (info-install being the package containing /sbin/ /sbin/install-info
> 2) plus manual %post or %posttrans calling install-info
> 
> This was a manual process, so it was sometimes missed in some pkgs.
> 
> We've replaced those manual requires+scriptlets by a filetrigger.
> But we still want info-install to be installed, so in order to replace
> the manual requires, we want to automatically emit the requires on
> info-install
> But we don't want to emit "requires: info-install",
> what we want really is "requires(posttrans): info-install"

No no no. Packages do not (and should not!) know what triggers might get 
run on them and what those triggers might need to do their job. 
Dependencies of trigger scripts need to be in the package containing 
those triggers.

I wouldn't be surprised if we have issues with ordering related to 
(file) triggers, but this is not the way to fix it. If you have a 
reproducer for a (file) trigger dependency related ordering issue, I'd 
certainly be interested.

> The patch enables to emit requires for scriptlets or filetriggers.

Scriptlet dependencies cannot be discovered by looking at the package 
content, they'd need to be discovered by looking at the script. So 
there's no valid use-case for generating scriptlet dependencies with the 
current dependency generator, and if we some day start generating 
autodependencies for the scriptlets themselves, the scriptlet type 
(pre/post etc) info is not going to come from file attributes anyway, it 
comes from the scriptlet itself. NAK.

	- Panu -