[Rpm-maint] [rpm-software-management/rpm] Warn if %else is after %else (#649)

[Panu Matilainen]

Anyway, overall looks quite nice. Bonus points if you can preserve the more accurate error message information, it seems like one could figure the after/without type info from the bitfield order maybe.

The biggest problem here is the commit messages :) The first commit mumbles something about removing zero value that will be used in the next commit, but that's not really true in this version. In fact for this version, you wouldn't need the value changes at all AFAICS. The second message is worse:

>  Use a general warning if a spec file conditional is on a wrong position

It's not a warning, it's an error.

> To parsedSpecLine_s and ReadLevelEntry were added additional data
> such that now it is able to make general type of error if ordering of
> conditionals is wrong.

This hubbub doesn't really convey what was achieved here, I barely understand even though I know what it's talking about. Please try rewriting in plain English, thanks :) 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/649#issuecomment-482556636
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190412/dfa67163/attachment.html>