[Rpm-maint] [rpm-software-management/rpm] Unify build-script running to always use rpmfcExec() (#670)

[Igor Gnatenko]

ignatenkobrain commented on this pull request.



>   * @return		buffered stdout from script, NULL on error
  */     
-static StringBuf getOutputFrom(ARGV_t argv,
-                        const char * writePtr, size_t writeBytesLeft,
-                        int failNonZero, const char *buildRoot)
+static int getOutputFrom(ARGV_t argv,

probably I would make this function to return rpmRC rather than (int), but up to you.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/670#pullrequestreview-227707791
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190417/231efb5d/attachment-0001.html>