[Rpm-maint] [rpm-software-management/rpm] Unify build-script running to always use rpmfcExec() (#670)

[Panu Matilainen]

pmatilai commented on this pull request.



>   * @return		buffered stdout from script, NULL on error
  */     
-static StringBuf getOutputFrom(ARGV_t argv,
-                        const char * writePtr, size_t writeBytesLeft,
-                        int failNonZero, const char *buildRoot)
+static int getOutputFrom(ARGV_t argv,

Actually rpmRC is wrong for 90% of the uses it's used for, especially in the build code. It's only really meaningful for package/header read operations, for pretty much everything else int is better.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/670#discussion_r276211638
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190417/bdf0ca1d/attachment.html>