[Rpm-maint] [rpm-software-management/rpm] Unify build-script running to always use rpmfcExec() (#670)
Panu Matilainen
notifications at github.com
Thu Apr 18 10:54:46 UTC 2019
pmatilai approved this pull request.
Yeah there are remnants of doc strings for various internal helpers all over the place, most of them long since fallen out of sync or just otherwise useless. Just axing them is often an act of mercy, if helpers need doc strings then usually a better fix is saner names.
I pondered a bit about suggesting leaving the stringbuf allocation entirely to the caller but that'd require further changes for no real benefit so probably not worth it. ACK.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/670#pullrequestreview-228220965
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190418/e922e03e/attachment.html>
More information about the Rpm-maint
mailing list