[Rpm-maint] [rpm-software-management/rpm] Cleanup and refactor addSource() for next steps (#678)

[Panu Matilainen]

Slice up addSource() to saner pieces to make it both more readable and preparing for next steps.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/678

-- Commit Summary --

  * Refactor spec source structure creation to helper function
  * Use findSource() for duplicate checking instead of manual copy-slop
  * Split icon handling out of addSource(), merge into readIcon()
  * Store source/patch/icon on-disk path in the source struct
  * Refactor Lua sources/patches handling to a helper function
  * Refactor source/patch download into a helper function
  * Make parseUnsignedNum() return code more obvious
  * Refactor tag number parsing out of addSource() to a helper function

-- File Changes --

    M build/build.c (8)
    M build/files.c (4)
    M build/misc.c (8)
    M build/parsePreamble.c (269)
    M build/parsePrep.c (12)
    M build/rpmbuild_internal.h (1)
    M build/rpmbuild_misc.h (4)
    M build/spec.c (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/678.patch
https://github.com/rpm-software-management/rpm/pull/678.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/678
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190424/b0bc17e2/attachment.html>