[Rpm-maint] [rpm-software-management/rpm] Warn if a text is after %else or %endif (#625)

[Panu Matilainen]

> As it is described in the commit message of the PR:
>
>  * a text after %else is expanded according to evaluation of the previous %if.
>  * a text after %endif is expanded according to evaluation of the previous %else, resp. %if if there was no %else.

So maybe it's just me, but this completely failed to drive the point across. "expanded according to evaluation" basically reads to me that "expansion depends on the evaluation" which makes me think "so, it's an %if, what do you expect?" Adding something like "contrary to expectations" would help make it more obvious what the problem is. 

Which is just to say that concrete tends to work better than abstract in commit messages and the like. Maybe something to the tune of "contrary to expectations, the entire %else line is considered to be a part of the preceeding %if block", and with a concrete example of what actually happens.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/625#issuecomment-461357329
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190207/1764d309/attachment.html>