[Rpm-maint] [rpm-software-management/rpm] Warn if a text is after %else or %endif (#625)

[Panu Matilainen]

pmatilai commented on this pull request.



>  static int expandMacrosInSpecBuf(rpmSpec spec, int strip)
 {
     char *lbuf = NULL;
+    char *auxBuf;

Like mentioned in an earlier review, this should be a const pointer since it's not used to modify the contents.
It's also unnecessarily in the outer scope when it's only used inside the if below.
Finally, *buf* is a weird and misleading name for a temporary pointer to some other string. "s" is commonly used for such pointers in codebase, similarly to how "i" is idiomatically used for indexing a for-loop.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/625#pullrequestreview-207336326
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190225/1e10b929/attachment.html>