[Rpm-maint] [rpm-software-management/rpm] Warn if a text is after %else or %endif (#625)

Panu Matilainen notifications at github.com
Mon Feb 25 11:16:19 UTC 2019


pmatilai commented on this pull request.



>  
     lbuf = spec->lbuf;
     SKIPSPACE(lbuf);
     if (lbuf[0] == '#')
 	isComment = 1;
 
+    lineTypeNumber = parseLineType(lbuf);
+    if (specLineTypes[lineTypeNumber].id & (LINE_ELSE | LINE_ENDIF)) {

The more appropriate test here would be whether the current directive type takes an argument or not. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/625#pullrequestreview-207337642
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190225/3f4d4260/attachment.html>


More information about the Rpm-maint mailing list