[Rpm-maint] [rpm-software-management/rpm] Warn if a text is after %else or %endif (#625)

[Panu Matilainen]

pmatilai commented on this pull request.



>  
-	ofi = pushOFI(spec, fileName);
-	goto retry;
+    if ((lineType = parseLineType(s))) {
+	if (!spec->readStack->reading && (lineType->id == LINE_IF)) {

Please jump to a goto label at the end instead of indenting the whole block. It's impossible to see what *really* changes when done like this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/625#pullrequestreview-207954170
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190226/09c377da/attachment.html>