[Rpm-maint] [rpm-software-management/rpm] Warn if a text is after %else or %endif (#625)

[Panu Matilainen]

Other than the huge block reindent, this looks quite promising but I'll wait for the indentation to be "fixed" before full review.

As a general note, patch reviewability is an important thing to consider then doing changes, and I don't mean the initial review only, it's at least as important later in when hunting bugs from commits etc.
In this case it's easy to avoid the indentation with a goto, but it's not always that simple. In such cases it's best to separate the indentation changes to another commit reinforced with a "indentation changes only" -type message.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/625#issuecomment-467444085
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190226/7a933dbd/attachment.html>