[Rpm-maint] [rpm-software-management/rpm] implement %elif (#613)

[Panu Matilainen]

pmatilai commented on this pull request.



> @@ -421,8 +422,8 @@ int readLine(rpmSpec spec, int strip)
 	    match = parseExpressionBoolean(s);
 	    if (match < 0) {
 		rpmlog(RPMLOG_ERR,
-			    _("%s:%d: bad %%if condition\n"),
-			    ofi->fileName, ofi->lineNum);
+			    _("%s:%d: bad %%if condition\n       expanded line:    %s"),
+			    ofi->fileName, ofi->lineNum, z);

The common style is to just output the line after a colon and without ado about expansions, ie
```
_("%s:%d: bad %%if condition: %s")
```

Lets stick to that please. Couple of other nits: 
- why include the possible preceding whitespace in the error message? 
- the commit message talks about %elif message but support for that hasn't been added yet

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/613#pullrequestreview-189743396
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190107/7a0e44d9/attachment.html>