[Rpm-maint] [rpm-software-management/rpm] implement %elif (#613)

pavlinamv notifications at github.com
Tue Jan 8 14:56:02 UTC 2019


If this comment is about patch
"Move checking whether %if condition will be resolved to the right place"
then the reply is:

I will improve the commit message. It should not speak about the "right place".
But it is not just refactoring because of `%elif`. The current place is not optimal because:
In function `readLine()`, all of conditionals (`%else`, `%endif`, `%ifarch`, `%ifnarch`, ...) except for `%if` are parsed in one place. But `%if` is parsed in two different places (there is `ISMACROWITHARG(s, "%if")` twice). I think that it is better to consolidate these two `ISMACROWITHARG(s, "%if")` into one place. And after that optimize it to be coded similarly as `%ifarch`, `%ifos`, ...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/613#issuecomment-452327087
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190108/4a354a19/attachment.html>


More information about the Rpm-maint mailing list