[Rpm-maint] [rpm-software-management/rpm] implement %elif (#613)

Panu Matilainen notifications at github.com
Wed Jan 9 13:11:40 UTC 2019


pmatilai commented on this pull request.



> @@ -360,7 +364,10 @@ do { \
 int readLine(rpmSpec spec, int strip)
 {
     char *s;
-    int match;
+    char *z;
+    int match = 0;
+    int isIf = 0;
+    int isElif = 0;

A line cannot be both an if and an elif, so there should only really be one variable to track it. I think some earlier version had something like that, dunno why you dropped it. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/613#pullrequestreview-190718012
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190109/d4b2e8a2/attachment.html>


More information about the Rpm-maint mailing list