[Rpm-maint] [rpm-software-management/rpm] Split verbose make flags to a separate macro (#799)
Neal Gompa (ニール・ゴンパ)
notifications at github.com
Thu Jul 25 02:16:43 UTC 2019
Conan-Kudo requested changes on this pull request.
> @@ -1073,7 +1073,8 @@ package or when debugging this package.\
#------------------------------------------------------------------------------
# The "make" analogue, hiding the _smp_mflags magic from specs
-%make_build %{__make} %{_make_output_sync} %{?_smp_mflags} V=1 VERBOSE=1
+%_make_verbose V=1 VERBOSE=1
+%make_build %{__make} %{_make_output_sync} %{?_smp_mflags} %{_make_verbose}
`%{_make_verbose}` -> `%{?_make_verbose}`
Also, can you put the `%_make_verbose` macro in its own "section" like `%_make_output_sync` was?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/799#pullrequestreview-266370469
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190724/23f32585/attachment.html>
More information about the Rpm-maint
mailing list