[Rpm-maint] [rpm-software-management/rpm] Compress annobin notes (#751)

[nickclifton]

Hi Colin,

> Can you keep the commit message title to < 80 chars? And move the text from the PR description into the commit message as well.

Sorry about that, I will remember for next time.

> Seems OK to me but: why don't the compilers do this by default?

Because at the time that the notes are created it is not possible
to determine which ones will actually be needed in the final executable.
(This is because of things like link-once sections, hot/cold partitioning
and so on).  The duplicate-eliminating and note-combining steps performed
by "objcopy --merge-notes" could in theory be performed by the linker, but
this has the problem that there are three linkers (ld.bfd, ld.gold, lld)
which would need to be modified, potentially introducing a lot more bugs.
Plus by putting the code into objcopy it means that binaries produced by
older linkers can still be processed.

Cheers
  Nick




-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/751#issuecomment-502677576
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190617/6f200388/attachment.html>