[Rpm-maint] [rpm-software-management/rpm] Test a macro from a macro file that contains %ifxxx - %endif (#640)

[pavlinamv]

> the macros can be defined in the spec directly

Yes, it is a good observation.

The spec file is changed to the proposed one.

>Then there's the issue of what it actually tries to test and what it expects - this is not really an expected failure but expected behavior, very similarly to how macros expanding in comments is. Normally you hardly notice it, but if there's a %define/%global in there...

> In these cases, the %if-%endif are processed as expected, but since the expansion (including the %global) occurs first, what the spec parser actually sees is just an empty %if-%endif. 

I think that the current behaviour is not expected by users. E.g. C don't evaluate #ifdef/#ifndef this way. Thus I let the test be "expected failure".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/640#issuecomment-471953146
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190312/64ba6b80/attachment-0001.html>