[Rpm-maint] [rpm-software-management/rpm] Correct rpm -ql exit value when optional -p is omitted (RhBug:1680610) (#641)
Panu Matilainen
notifications at github.com
Thu Mar 14 11:25:20 UTC 2019
- Use rpmFileHasSuffix() instead of manual calculation (yes I know you're not adding the calculation, but might as well get rid of it while touching the code)
- Pretty please, no numbered variables unless the number is a meaningful part of the of the name (eg in coordinates x1, y1, x2, y2 are meaningful). If you can come up with a name/abbreviation that's actually meaningful to the context, great. If not, "xx" is commonly used these sort of internal, temporary error codes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/641#issuecomment-472811106
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190314/9fc082c7/attachment.html>
More information about the Rpm-maint
mailing list