[Rpm-maint] [rpm-software-management/rpm] Also test architecture in "refresh" test when not colored. (#253)

[Panu Matilainen]

pmatilai commented on this pull request.



> @@ -511,13 +511,14 @@ void rpmpsmNotify(rpmpsm psm, int what, rpm_loff_t amount)
  */
 static void markReplacedInstance(rpmts ts, rpmte te)
 {
+    /* this must match rpmNameVersionCompare in depends.c */

> We do have rpmNameVersionCompare in depends.c. See the nameversioncompare.diff patch...

(encountered when looking at something else)

The name comparison in that patch has been redundant for a long long time BTW. It used to be necessary back in the days of implicit obsoletes of rpm < 4.4.2.1 when the iterator walked provides, but unnecessary ever since commit 036e9e6dcb8165bb5862b55c6e8825161d78775c. The arch part is more complicated of course.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/253#discussion_r269530383
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190327/83160f28/attachment.html>