[Rpm-maint] [rpm-software-management/rpm] Add support for audit logging package operations via plugin (#648)

[Panu Matilainen]

pmatilai commented on this pull request.



> +    if (auditFd < 0)
+	goto exit;
+
+    int nelem = rpmtsNElements(ts);
+    struct teop *ops = xcalloc(nelem, sizeof(*ops));
+    char *dir = audit_encode_nv_string("root_dir", rpmtsRootDir(ts), 0);
+    int enforce = (rpmtsVfyLevel(ts) & RPMSIG_SIGNATURE_TYPE) != 0;
+
+    getAuditOps(ts, ops, nelem);
+
+    for (int i = 0; i < nelem; i++) {
+	const char *op = ops[i].op;
+	if (op) {
+	    rpmte p = ops[i].te;
+	    char *nevra = audit_encode_nv_string("sw", rpmteNEVRA(p), 0);
+	    char eventTxt[256];

Anyway... these kind of hardcoded buffersizes for strings belong to the nineties, and it's actually even buggy in the case the string happened to be larger than the hardcoded buffer as the string wont be terminated in that case. Pushed an updated version with dynamically allocated string.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/648#discussion_r270387752
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190329/173ab666/attachment.html>