[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)

[Panu Matilainen]

pmatilai commented on this pull request.



> @@ -213,24 +278,58 @@ static rpmRC buildSpec(BTA_t buildArgs, rpmSpec spec, int what)
     } else {
 	int didBuild = (what & (RPMBUILD_PREP|RPMBUILD_BUILD|RPMBUILD_INSTALL));
 
+	if (!spec->buildrequires && (what & RPMBUILD_PACKAGESOURCE) &&
+	    !(what & (RPMBUILD_BUILD|RPMBUILD_INSTALL|RPMBUILD_PACKAGEBINARY))){

This would far easier to read if at least part of it was split into a helper variable, similar to didBuild above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-235953811
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190510/1be91f74/attachment.html>