[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)

[Panu Matilainen]

pmatilai commented on this pull request.



>   * @param spec		spec file control structure
  * @param buildArgs	build arguments
- * @return		RPMRC_OK on success
+ * @return		0 on success, 1 on build error,
+ *			RPMRC_MISSINGBUILDREQUIRES on missing build

The return values are bit of a mishmash, some numeral and some RPMRC_ value that's not really an RPMRC afterall. Would be more consistent to return RPMRC_* constants for everything (but keep return type as int because of RPMRC_MISSINGBUILDREQUIRES). That, or just talk about numbers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-238228374
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190516/081ebd6e/attachment-0001.html>