[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
Panu Matilainen
notifications at github.com
Thu May 16 07:58:30 UTC 2019
As the GH interface doesn't allow commenting on individual commits, I'll just make a general comment... In the "Pass rpmts object to rpmSpecBuild()" commit, there are two minor issues:
- a stray empty line added before buildSpec()
- a change to rpmbuild.c that belongs to the next commit (move to library, return 11 on missing buildrequires)
Other than that, and the missing tests, it's looking quite okay now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#issuecomment-492961283
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190516/e79c090f/attachment.html>
More information about the Rpm-maint
mailing list